magento/magento2#39905 Product Removed on Mobile Still Appears in Web's Mini Compare Section Until Re-login #40023

KrasnoshchokBohdan · 2025-06-26T07:20:06Z

Description (*)

createCompareList

mutation {
  createCompareList(
    input: {
      products: ["1", "2"]
    }
  ) {
    uid
    item_count
    attributes {
      code
      label
    }
    items {
      uid
      product {
        sku
        name
        description {
          html
        }
      }
    }
  }
}

addProductsToCompareList

mutation {
  addProductsToCompareList(
    input: { uid: "-", products: ["3"] }
  ) {
    uid
    item_count
    attributes {
      code
      label
    }
    items {
      uid
      product {
        sku
        name
        description {
          html
        }
      }
    }
  }
}

removeProductsFromCompareList

mutation {
  removeProductsFromCompareList(
    input: { uid: "-", products: ["2"] }
  ) {
    uid
    item_count
    attributes {
      code
      label
    }
    items {
      uid
      product {
        sku
        name
        description {
          html
        }
      }
    }
  }
}

After these mutations, the counter in the header and in the customer account does not change. I found \Magento\Catalog\Helper\Product\Compare::calculate, which updates the quantity in _catalogSession, but the counters actually get their data from the customer data (compare-products section). To get an accurate quantity, the session needs to be updated, which is quite contradictory when considering the issue in the GraphQL scope.

Related Pull Requests

Fixed Issues (if relevant)

Fixes magento/magento2#39905

Manual testing scenarios (*)

Use any GraphQL mutation from the PR description.
Log in as a customer and go to /catalog/product_compare/index/
Go to /customer/account/index/ and check the "Compare Products" section.

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)
[ ]

…ompare Section Until Re-login Integrates the Product Compare helper across compare list resolvers to trigger updates after adding, removing, or creating compare lists. Also forces a reload of compare product data on the frontend to maintain accuracy.

m2-assistant · 2025-06-26T07:20:10Z

Hi @KrasnoshchokBohdan. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

KrasnoshchokBohdan · 2025-06-26T07:24:46Z

@magento run all tests

Den4ik

Hi @KrasnoshchokBohdan
Thanks for your PR.
Could you please fix static tests and add new tests for fixed issue?
Thanks

KrasnoshchokBohdan · 2025-06-26T09:12:54Z

app/code/Magento/Catalog/view/frontend/web/js/view/compare-products.js

@Den4ik Hi!
Sorry to bother you. I probably should have marked this as a draft immediately.
Currently, I'm struggling with a solution for reloading the compare-product customer section after changes made by a GraphQL mutation (

Hi @KrasnoshchokBohdan
Thanks for details

…ompare Section Until Re-login Introduced CompareCookieManager to manage cookie invalidation for compare list products. Updated resolvers to use this service and ensure cookies are marked invalid after product compare list operations. Removed redundant client-side cookie reload logic in the frontend.

KrasnoshchokBohdan · 2025-06-27T09:27:59Z

@magento run all tests

KrasnoshchokBohdan · 2025-06-27T15:35:58Z

@magento run all tests

…ompare Section Until Re-login Introduced `CompareCookieManager` enhancements with better cookie management through visibility modifiers and documentation changes. Suppressed warnings for PHPMD where relevant and added comprehensive unit tests for cookie handling, including edge cases like size limits and failures.

KrasnoshchokBohdan · 2025-06-28T16:22:12Z

@magento run all tests

…ompare Section Until Re-login - Static tests fix

KrasnoshchokBohdan · 2025-06-30T06:45:47Z

@magento run all tests

KrasnoshchokBohdan · 2025-06-30T13:55:42Z

@magento run Unit Tests

KrasnoshchokBohdan · 2025-07-01T09:11:42Z

@Den4ik, the only solution I found for now is to change compare-products cookie, so if you have any comments or suggestions, I will be happy to consider them

Den4ik · 2025-07-02T09:35:42Z

Hi @KrasnoshchokBohdan
I don't mind using cookies manager, but want to check it locally.

…ompare Section Until Re-login Refactor CompareCookieManager to use readonly properties Replaced manually assigned properties with readonly properties in the constructor to simplify initialization and improve immutability. Updated exception handling to use the imported Exception class instead of a fully qualified name.

KrasnoshchokBohdan · 2025-09-27T12:23:20Z

@magento run all tests

engcom-Hotel · 2025-09-29T12:40:01Z

@magento run all tests

engcom-Hotel

Failed tests seems to flaky, hence approving the PR.

engcom-Bravo · 2025-10-06T06:24:01Z

@magento run all tests

engcom-Bravo · 2025-10-06T09:32:46Z

Hi @KrasnoshchokBohdan,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop

Manual testing scenarios

Use any GraphQL mutation from the PR description.
Log in as a customer and go to /catalog/product_compare/index/
Go to /customer/account/index/ and check the "Compare Products" section.

Before: ✖️

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

engcom-Charlie · 2025-10-06T09:51:50Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Unit Tests

engcom-Charlie · 2025-10-06T14:27:03Z

@magento run Functional Tests B2B

engcom-Charlie · 2025-10-07T06:23:04Z

The Functional B2B and EE failures in recent 2 builds are not consistent. They are neither part of this PR nor failing because of the PR changes, seems to be flaky hence moving it to Merge In Progress.

Functional B2B: Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40023/d37187af45d8d450ee3c583f6edec148/Functional/allure-report-b2b/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40023/f65960d288cb0184b15c5ce76aca2bd3/Functional/allure-report-b2b/index.html#categories

Functional EE: Run 1:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40023/02579a52420d9cf083cd99ce13e7e90d/Functional/allure-report-ee/index.html#categories

Run 2:
https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/40023/10982ee17b2be04487e7634e80fe1874/Functional/allure-report-ee/index.html#categories

Merge branch '2.4-develop' into fix-for-issue-39905

7b8032d

Den4ik requested changes Jun 26, 2025

View reviewed changes

KrasnoshchokBohdan commented Jun 26, 2025

View reviewed changes

KrasnoshchokBohdan marked this pull request as draft June 26, 2025 09:40

KrasnoshchokBohdan and others added 2 commits June 27, 2025 12:26

Merge branch '2.4-develop' into fix-for-issue-39905

ccda198

Merge branch '2.4-develop' into fix-for-issue-39905

a70613e

KrasnoshchokBohdan and others added 2 commits June 30, 2025 09:44

magento#39905 Product Removed on Mobile Still Appears in Web's Mini C…

3220e13

…ompare Section Until Re-login - Static tests fix

Merge branch '2.4-develop' into fix-for-issue-39905

c94057e

KrasnoshchokBohdan marked this pull request as ready for review July 1, 2025 06:39

engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 1, 2025

ct-prd-projects-boards-automation bot added this to Pull Requests Dashboard Jul 1, 2025

github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Jul 1, 2025

ct-prd-projects-boards-automation bot added the Progress: pending review label Jul 1, 2025

KrasnoshchokBohdan requested a review from Den4ik July 1, 2025 09:12

ct-prd-projects-boards-automation bot added Progress: review and removed Progress: pending review labels Jul 1, 2025

ct-prd-projects-boards-automation bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard Jul 1, 2025

sidolov added the Partner: Perspective label Jul 17, 2025

ct-prd-projects-boards-automation bot removed the Progress: review label Sep 15, 2025

KrasnoshchokBohdan and others added 2 commits September 27, 2025 15:18

Merge branch '2.4-develop' into fix-for-issue-39905

402ce4f

Merge branch '2.4-develop' into fix-for-issue-39905

450ce29

engcom-Hotel approved these changes Sep 30, 2025

View reviewed changes

ct-prd-projects-boards-automation bot moved this from Changes Requested to Ready for Testing in Community Dashboard Sep 30, 2025

ct-prd-projects-boards-automation bot added Progress: ready for testing Progress: review and removed Progress: needs update labels Sep 30, 2025

ct-prd-projects-boards-automation bot moved this from Ready for Testing to Review in Progress in Community Dashboard Sep 30, 2025

engcom-Hotel moved this from Review in Progress to Ready for Testing in Community Dashboard Sep 30, 2025

engcom-Hotel removed the Progress: review label Sep 30, 2025

engcom-Bravo self-assigned this Oct 6, 2025

engcom-Bravo moved this from Ready for Testing to Testing in Progress in Community Dashboard Oct 6, 2025

Merge branch '2.4-develop' into fix-for-issue-39905

b0c0764

engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard Oct 6, 2025

engcom-Charlie moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Oct 7, 2025

engcom-Charlie removed the Progress: ready for testing label Oct 7, 2025

engcom-Charlie self-assigned this Oct 7, 2025

engcom-Charlie added the Progress: deployment queue label Oct 10, 2025

magento-devops-reposync-svc merged commit 8aa02bb into magento:2.4-develop Nov 4, 2025
10 of 12 checks passed

ct-prd-projects-boards-automation bot moved this from Merge in Progress to Recently Merged in Community Dashboard Nov 4, 2025

engcom-Charlie removed the Progress: deployment queue label Nov 4, 2025

magento/magento2#39905 Product Removed on Mobile Still Appears in Web's Mini Compare Section Until Re-login #40023

magento/magento2#39905 Product Removed on Mobile Still Appears in Web's Mini Compare Section Until Re-login #40023

Uh oh!

Conversation

KrasnoshchokBohdan commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jun 26, 2025

Uh oh!

KrasnoshchokBohdan commented Jun 26, 2025

Uh oh!

Den4ik left a comment

Choose a reason for hiding this comment

Uh oh!

KrasnoshchokBohdan Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Den4ik Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

KrasnoshchokBohdan commented Jun 27, 2025

Uh oh!

KrasnoshchokBohdan commented Jun 27, 2025

Uh oh!

KrasnoshchokBohdan commented Jun 28, 2025

Uh oh!

KrasnoshchokBohdan commented Jun 30, 2025

Uh oh!

KrasnoshchokBohdan commented Jun 30, 2025

Uh oh!

KrasnoshchokBohdan commented Jul 1, 2025

Uh oh!

Den4ik commented Jul 2, 2025

Uh oh!

KrasnoshchokBohdan commented Sep 27, 2025

Uh oh!

engcom-Hotel commented Sep 29, 2025

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Bravo commented Oct 6, 2025

Uh oh!

engcom-Bravo commented Oct 6, 2025

✔️ QA Passed

Uh oh!

engcom-Charlie commented Oct 6, 2025

Uh oh!

engcom-Charlie commented Oct 6, 2025

Uh oh!

engcom-Charlie commented Oct 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

KrasnoshchokBohdan commented Jun 26, 2025 •

edited

Loading

KrasnoshchokBohdan Jun 26, 2025 •

edited

Loading